Skip to content

[Frontend] Add doc Watch Options configuration #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Frontend] Add doc Watch Options configuration #11398

wants to merge 2 commits into from

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Apr 10, 2019

Hi,

This PR add a new page that shows how to easily configure watching options with Encore:

Encore.configureWatchOptions(watchOptions => {
  watchOptions.poll = 250;
});

I've also reworked the Advanced Config page to remove the old way to configure watch options.

Thanks!

@javiereguiluz
Copy link
Member

@Kocal thanks a lot for this and all the other Encore related contributions. We merged it in the 3.4 branch and we changed it a bit. We don't want article that are too short, because they break the reading flow of a normal article into multiple small articles.

That's why we've removed the 14-line long frontend/encore/watch-options.rst article and moved its contents back into the main article about advanced Encore features. I hope you understand it. Thanks.

@Kocal
Copy link
Member Author

Kocal commented Apr 11, 2019

Oops I forgot to change branch to 3.4. 😅

Yes don't worry, that's totally normal. :)

@Kocal Kocal deleted the encore/watch-options branch April 11, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants